Fix #2534 - shared boundary issue: skip extract-largest-component for shared boundary domains#2535
Open
akenmorris wants to merge 3 commits intomasterfrom
Open
Fix #2534 - shared boundary issue: skip extract-largest-component for shared boundary domains#2535akenmorris wants to merge 3 commits intomasterfrom
akenmorris wants to merge 3 commits intomasterfrom
Conversation
…boundary domains, add empty mesh crash guards
- MeshUtils: replace fragile is_clockwise atan2 test with summed signed-area vector (uses all vertices, immune to branch-cut flips); rotate boundary loops to start at canonical max-Y vertex for consistent ordering across subjects. - ContourDomain: return length² from GetSurfaceArea so contours participate in sampling-scale auto-scaling at a magnitude comparable to meshes. - SamplingFunction: apply auto-scale uniformly; contours no longer require special-case skipping. - GroomParameters: skip phantom shared-boundary entry on migration when domain names are empty. - Regenerate shared boundary test ground truth for canonical start vertex.
- Add ElidedLabel class that truncates long domain names with "..." when column space is tight, while reporting full-text sizeHint so the layout allocates natural width when available. Full name shown as tooltip. - Cap optimize textboxes to 50-100px (min/max) so they don't expand and crowd out the label column; ensures values like "0.05" aren't truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix shared boundary issue: skip extract-largest-component for shared boundary domains
Before:
After: