fix(ast): update lodash to 4.18.1 to patch CVE-2026-2950 and CVE-2026-4800#466
Open
TwitchBronBron wants to merge 1 commit into
Open
fix(ast): update lodash to 4.18.1 to patch CVE-2026-2950 and CVE-2026-4800#466TwitchBronBron wants to merge 1 commit into
TwitchBronBron wants to merge 1 commit into
Conversation
Lodash 4.17.23 is affected by: - CVE-2026-2950: prototype pollution bypass in _.unset/_.omit (bypasses the fix for CVE-2025-13465 via array-wrapped path segments) - CVE-2026-4800: code injection in _.template (CVSS 9.8) when untrusted input is used as options.imports key names Bumps the pinned version from 4.17.23 to ^4.18.1 which contains the patches for both issues. All 26 existing tests continue to pass.
00935f7 to
514edf3
Compare
Author
|
It seems like the build failure for build-node22 is because of coverage uploading? Any chance we could get that fixed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@xml-tools/astpackage pinslodashat4.17.23, which is affected by two security vulnerabilities patched in4.18.0:_.unset/_.omit— the fix for CVE-2025-13465 only guarded string key members; an attacker can bypass it via array-wrapped path segments, allowing deletion of properties from built-in prototypes (Object.prototype, etc.)_.template— arbitrary code execution when untrusted input is passed asoptions.importskey namesDownstream consumers are currently forced to use
overrides/resolutionsin their ownpackage.jsonto work around these advisories. Fixing it here removes that burden.Change
Changed from an exact pin to a caret range so future patch releases are picked up automatically.
Test plan
npm testinpackages/ast— all 26 tests pass before and after the change4.18.1npm auditno longer reports lodash vulnerabilities after the update