Skip to content

feat: use dedicated fragments for AGW token generation#137

Merged
NicoleMGomes merged 3 commits into
mainfrom
feat/agw-contribution
May 29, 2026
Merged

feat: use dedicated fragments for AGW token generation#137
NicoleMGomes merged 3 commits into
mainfrom
feat/agw-contribution

Conversation

@NicoleMGomes
Copy link
Copy Markdown
Contributor

@NicoleMGomes NicoleMGomes commented May 25, 2026

PR recreated from contrib #110 extended with tests

Description

Adding token fetching based on dedicated AGW fragments for the AGW client. Additionally it exposes the URL of AGW as fetched from the fragment.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

  1. Use an agent that has the new fragment generation applied
  2. Make sure that these fragments were created for your test tenant
  3. Do a regression test of the existing client functionality
  4. Also test whether the standalone auth fetching functions work and return valid tokens + URLs

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

@NicoleMGomes NicoleMGomes force-pushed the feat/agw-contribution branch 4 times, most recently from 1336220 to 9c4fe92 Compare May 26, 2026 00:01
@NicoleMGomes NicoleMGomes marked this pull request as ready for review May 26, 2026 00:06
@NicoleMGomes NicoleMGomes requested a review from a team as a code owner May 26, 2026 00:06
Copy link
Copy Markdown
Contributor

@prashantrakheja prashantrakheja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested customer flow with system credentials, minor comments

Comment thread src/sap_cloud_sdk/agentgateway/_lob.py Outdated
Comment thread tests/agentgateway/integration/agw_auth.feature
@NicoleMGomes NicoleMGomes force-pushed the feat/agw-contribution branch from c282a11 to 2922fdb Compare May 29, 2026 13:57
@NicoleMGomes NicoleMGomes merged commit 6b328db into main May 29, 2026
10 of 11 checks passed
@NicoleMGomes NicoleMGomes deleted the feat/agw-contribution branch May 29, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants