feat: add DestinationHttpClient to simplify calls to target systems#119
feat: add DestinationHttpClient to simplify calls to target systems#119jplbrun wants to merge 3 commits into
Conversation
|
|
||
|
|
||
| class DestinationHttpClient: | ||
| """Wraps requests.Session to call the target system described by a Destination. |
There was a problem hiding this comment.
Is it really necessary for us to wrap the requests.Session object? I mean we are wrapping all the methods from requests.Session (get, put, post, delete and request) without doing anything extra.
Maybe we could just offer a factory for developers to create a Session object populated with the necessary headers from the destination.
There was a problem hiding this comment.
I believe we don't need to return Session, but we could expose a single method of request allowing selection of path and HttpMethod
| # Pre-bake auth headers — BTP may return multiple tokens, skip empty ones | ||
| for token in destination.auth_tokens: | ||
| key = token.http_header.get("key") | ||
| value = token.http_header.get("value") | ||
| if key and value: | ||
| self._session.headers[key] = value |
There was a problem hiding this comment.
What about token refreshing?
|
Update user-guide |
| self._session = requests.Session() | ||
|
|
||
| # Pre-bake sap-client / sap-language — relevant mainly for OnPremise destinations | ||
| self._session.headers.update(destination.get_erp_headers()) |
There was a problem hiding this comment.
All headers from destination should be used, not only token and erp. Is this the case?
3 participants
Description
Adds
DestinationHttpClient, arequestswrapper that makes calling a target system from a destination straightforward. Previously, users had to manually fetch an auth token from destination properties and build theAuthorizationheader themselves, and also manually set thesap-clientheader for OnPremise destinations. With this change:The client pre-bakes auth headers from
dest.auth_tokens(populated by the v2 API) and SAP ERP headers (sap-client,sap-language) into the session at construction time.Type of Change
How to Test
dest = client.get_destination("my-destination")http = DestinationHttpClient(dest)response = http.get("/api/resource")uv run pytest tests/destination/unit/test_destination_http_client.py -vRelated Issue
Closes #35
Checklist