ci: integrate yeoman-ui into app-studio-toolkit monorepo #503
Open
alex-gilin wants to merge 6 commits into
Open
ci: integrate yeoman-ui into app-studio-toolkit monorepo #503alex-gilin wants to merge 6 commits into
alex-gilin wants to merge 6 commits into
Conversation
alex-gilin
force-pushed
the
oss-transition/yeoman-ui
branch
from
6875802 to
c05b649
Compare
- Wire pnpm workspace, root tsconfig references, and ESLint config for the projects/yeoman-ui sub-tree - Drop intermediate projects/yeoman-ui/package.json (Lerna/Yarn artefact); coverage:copy paths updated to write directly into root coverage/ - Add tsconfig.base.json and .eslintrc.js under projects/yeoman-ui with correct paths relative to the monorepo root - Migrate package metadata (repository, bugs, homepage) in all four packages from SAP/yeoman-ui to SAP/app-studio-toolkit - Fix CI artifact upload glob to include projects/yeoman-ui/packages/backend/*.vsix - Add root-level app-studio-toolkit.code-workspace for multi-root VS Code support; add projects/yeoman-ui/.vscode with launch, tasks, and settings - Update all docs (README, CONTRIBUTING, package READMEs) to reflect new repo location, pnpm toolchain, and Changesets release process - Fix pre-commit hook PATH resolution via ~/.huskyrc for nvm environments
- Move pnpm overrides from package.json (ignored in pnpm v11) to pnpm-workspace.yaml so terser-webpack-plugin resolves terser@5.48.0 instead of 5.31.6, fixing the Terser parse error on ES2020+ class syntax - Restore webpack optimization.minimizer with TerserPlugin (keep_classnames, keep_fnames, ecma:2020) required for ESM generator dynamic import support
alex-gilin
force-pushed
the
oss-transition/yeoman-ui
branch
from
06e030f to
74b0bcc
Compare
Contributor
Build ReportPlease note:
|
Adding yeoman-ui packages (which use jest@29) to the workspace caused jest@29's jest-environment-node to land in the pnpm shared fallback node_modules. jest@27 (used by webide-client-tools) then resolved it from there instead of its own v27, crashing with: Cannot read properties of undefined (reading 'testEnvironmentOptions') Pin jest-runner>jest-environment-node and jest-config>jest-environment-node to 27.5.1 via pnpm-workspace.yaml overrides to keep the two major versions isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.