SapMachine #1985: Fix sync-fork-checks concurrency group to be per-PR#2325
Merged
RealCLanger merged 1 commit intoJul 3, 2026
Conversation
Member
|
Hello @RealCLanger, this pull request fulfills all formal requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sync-fork-checks.ymlworkflow used${{ github.ref }}as the concurrency group key. Forpull_request_targetevents,github.refresolves to the base branch (e.g.refs/heads/sapmachine), not the PR branch — so all open PRs targeting the same base branch shared one concurrency slot, and a new run for any PR would cancel the currently-running one for any other PR.Two fixes:
${{ github.event.pull_request.number }}in the concurrency group key so each PR gets its own slot.cancelled()cleanup step that marks any in-progress check runs for the commit as cancelled, preventing danglingin_progresscheck runs on the PR when the job is superseded.fixes #1985