Merged
Conversation
doesn't happen at module level, making testing a bit easier.
jeremyestein
force-pushed
the
jeremy/opt-outs
branch
from
7b83c61 to
be9804e
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement opt-out SAFEHR-data/emap#155
We send a "reject without requeue" to rabbitmq for the message and don't write anything out to disk. See also synthetic generator change SAFEHR-data/emap#156 that sets a random 10% of MRNs to be opted out.
Also add unit tests to test opt-out, as well as general error handling in the controller. Fixed one bug discovered this way. Did a small refactor to make controller more testable. So this partially counts towards #23 .
You may want to turn on "hide whitespace" while reviewing this change, as I have refactored some module-level code into a class in
src/controller.py.