fix: add maxConcurrentFileReads limit to native read_file tool schema

[roomote]

Related GitHub Issue

This PR addresses an internal issue identified via Slack thread - models were attempting to read too many files in the native read_file tool because the maxConcurrentFileReads limit was not documented in the tool schema.

Roo Code Task Context (Optional)

This fix was developed using Roo Code.

Description

The native tool schema for read_file was missing documentation about the maxConcurrentFileReads limit. This caused models to request more files than allowed when using native tool protocols (e.g., in cloud jobs with restricted limits), only discovering the limit after receiving runtime errors.

Key changes:

• Update createReadFileTool to accept a maxConcurrentFileReads option via a new ReadFileToolOptions interface
• Dynamically include the file read limit in the tool description
• When maxConcurrentFileReads is 1, the description now clearly states "Multiple file reads are currently disabled. You can only read one file at a time."
• When maxConcurrentFileReads > 1, the description states "You can read a maximum of X files in a single request"
• Update getNativeTools to accept and pass the maxConcurrentFileReads option
• Update buildNativeToolsArray to pass the limit through the call chain from Task.ts

Before: The tool description said "request related files together when allowed" without specifying what the limit was.

After: The tool description explicitly states the limit, e.g., "IMPORTANT: You can read a maximum of 5 files in a single request. If you need to read more files, use multiple sequential read_file requests."

Test Procedure

1. Added comprehensive test suite in src/core/prompts/tools/native-tools/__tests__/read_file.spec.ts:

   • Tests for default maxConcurrentFileReads limit (5) in description
   • Tests for custom maxConcurrentFileReads limits
   • Tests for single file reads (limit=1)
   • Tests for combined options with partialReadsEnabled
   • Tests for tool structure validation

2. Run the tests:

   cd src && npx vitest run core/prompts/tools/native-tools/__tests__/read_file.spec.ts

3. All existing tests pass:

   cd src && npx vitest run core/prompts/tools/native-tools
   cd src && npx vitest run core/prompts/tools/__tests__/filter-tools-for-mode.spec.ts

Pre-Submission Checklist

• Issue Linked: This PR addresses an internal issue from Slack thread (no GitHub issue).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes.
• Documentation Impact: No external documentation updates required - this is an internal implementation detail.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - This is a backend/prompt change with no UI impact.

Documentation Updates

• No documentation updates are required.

Additional Notes

This fix ensures that when cloud jobs set a low maxConcurrentFileReads value (like 1), models will know about this constraint upfront in the tool schema rather than discovering it through runtime errors. This should significantly reduce wasted tokens from failed file read attempts.

Get in Touch

Roo Code Agent

---

Important

Add maxConcurrentFileReads limit to read_file tool schema for controlled file read operations, with updated descriptions and tests.

• Behavior:
  • Add maxConcurrentFileReads option to createReadFileTool in read_file.ts.
  • Update tool description to reflect maxConcurrentFileReads limit.
  • Modify getNativeTools in index.ts to pass maxConcurrentFileReads.
  • Update buildNativeToolsArray in build-tools.ts to include maxConcurrentFileReads.
• Tests:
  • Add tests in read_file.spec.ts for default and custom maxConcurrentFileReads limits.
  • Test single file reads and combined options with partialReadsEnabled.
• Misc:
  • Update Task.ts to handle maxConcurrentFileReads in task configuration.

^{This description was created by for d1616f1. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. No issues found.

The latest changes (d1616f1) are a description cleanup that improves tool description clarity by using appropriate singular/plural forms based on maxConcurrentFileReads. The implementation correctly adds the maxConcurrentFileReads limit documentation to the native read_file tool schema with comprehensive test coverage.

Previous reviews

• 3389643: Review #1
• 9bff336: Review #2

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[mrubens]

@roomote fix the failing check

[roomote]

Fixaroo   See task on Roo Cloud

Fixed the TypeScript compile error by using a FunctionTool type intersection pattern for proper type inference. All local checks passed.

_{View commit | Revert commit}