-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: restore tool protocol selector for OpenAI Compatible provider #10300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Re-adds the Tool Protocol selector for OpenAI Compatible providers that was removed in PR #10281. This allows users with third-party API proxies to select XML protocol as a workaround when their provider does not fully support native tool calling. Changes: - Add Tool Protocol selector to OpenAICompatible.tsx - Update resolveToolProtocol() to respect user preference for openai provider - Add tests for OpenAI Compatible provider tool protocol selection Fixes #10246
Review completed. No issues found. Summary:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
Please solve this bug fastly. |
Verified PR is complete and ready for review. All local checks passed (30 tests, TypeScript checks). Marked PR as ready for review. |
|
the Tool Protocol selector for OpenAI Compatible providers that Changes:
PLZ fix this error!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! |
Review complete. No issues found. The PR correctly restores the Tool Protocol selector for OpenAI Compatible providers, addressing issue #10246. The implementation is type-safe, well-tested, and all i18n translations are in place. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
This PR fixing so slow |
https://blog.roocode.com/p/sorry-we-didnt-listen-sooner-native
|
Related GitHub Issue
Closes: #10246
Description
This PR attempts to address Issue #10246 where users with third-party API providers (OpenAI Compatible) are unable to switch between Native and XML tool protocols after the XML protocol was deprecated in PR #10281.
The Problem:
PR #10281 removed the Tool Protocol selector from the UI and forced all providers to use Native tool calling. However, many third-party API proxies do not fully support native tool calling, causing errors like:
The Solution:
This PR re-adds the Tool Protocol selector specifically for OpenAI Compatible providers, allowing users to manually select XML protocol as a workaround when their third-party proxy does not support native tool calling.
Changes:
resolveToolProtocol()to respect user preference for openai providerBehavior:
Test Procedure
cd src && npx vitest run utils/__tests__/resolveToolProtocol.spec.tscd src && npx tsc --noEmit --skipLibCheckcd webview-ui && npx tsc --noEmit --skipLibCheckManual testing:
Pre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome!
Important
Reintroduces tool protocol selector for OpenAI Compatible providers, allowing XML or Native protocol selection based on user preference.
OpenAICompatible.tsxfor OpenAI Compatible providers.resolveToolProtocol()to respect user preferences for OpenAI Compatible providers.resolveToolProtocol.spec.tsfor OpenAI Compatible provider tool protocol selection.OpenAICompatible.tsxto select tool protocol (XML or Native).This description was created by
for fda4984. You can customize this summary. It will automatically update as commits are pushed.