Skip to content

BUG: Remove duplicate controller process #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MateusStano merged 2 commits into from
Apr 4, 2026
+1 −10
Merged

BUG: Remove duplicate controller process #949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d227a
Remove duplicate controller process
zuorenchen Apr 4, 2026
b23ab58
Bug: process sensor if node._component_sensors exist instead of fligh…
zuorenchen Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions rocketpy/simulation/flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,15 +698,6 @@ def __simulate(self, verbose):

self.__process_sensors_and_controllers_at_current_node(node, phase)

for controller in node._controllers:
controller(
self.t,
self.y_sol,
self.solution,
self.sensors,
self.env,
)

for parachute in node.parachutes:
# Calculate and save pressure signal
(
Expand Down Expand Up @@ -853,7 +844,7 @@ def __process_sensors_and_controllers_at_current_node(self, node, phase):
phase : FlightPhase
The current flight phase.
"""
if self.sensors:
if node._component_sensors:
u_dot = phase.derivative(self.t, self.y_sol)
self.__measure_sensors(node._component_sensors, u_dot)

Expand Down