fix: Use new image_transport API when applicable#203
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates web_video_server to compile against newer ROS 2 (rolling) by switching QoS handling to rclcpp::QoS and conditionally using the newer image_transport API where required.
Changes:
- Replace
rmw_qos_profile_t-based QoS selection withrclcpp::QoS(get_qos_profile_from_name). - Update streamers to use the new QoS type and, for
image_transport, select the correct API via a compile definition. - Add a CMake version gate to define
IMAGE_TRANSPORT_USES_OLD_APIfor olderimage_transportversions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils.cpp |
Switch QoS helper implementation to construct/return rclcpp::QoS. |
include/web_video_server/utils.hpp |
Update QoS helper declaration to return std::optional<rclcpp::QoS>. |
src/streamers/ros_compressed_streamer.cpp |
Adapt compressed-image subscriber QoS creation to the new QoS type. |
src/streamers/image_transport_streamer.cpp |
Use old vs. new image_transport API signatures conditionally and pass QoS appropriately. |
CMakeLists.txt |
Gate old/new image_transport API usage via image_transport_VERSION. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
This fixes the build on rolling which recently removed the old API entirely.
The CI fails due to clang-tidy errors which I'll fix in another PR