Skip to content

fix: Use new image_transport API when applicable#203

Merged
bjsowa merged 6 commits into
ros2from
fix/deprecated-api
Jul 2, 2026
Merged

fix: Use new image_transport API when applicable#203
bjsowa merged 6 commits into
ros2from
fix/deprecated-api

Conversation

@bjsowa

@bjsowa bjsowa commented Jun 30, 2026

Copy link
Copy Markdown
Member

Public API Changes
None

Description
This fixes the build on rolling which recently removed the old API entirely.

The CI fails due to clang-tidy errors which I'll fix in another PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates web_video_server to compile against newer ROS 2 (rolling) by switching QoS handling to rclcpp::QoS and conditionally using the newer image_transport API where required.

Changes:

  • Replace rmw_qos_profile_t-based QoS selection with rclcpp::QoS (get_qos_profile_from_name).
  • Update streamers to use the new QoS type and, for image_transport, select the correct API via a compile definition.
  • Add a CMake version gate to define IMAGE_TRANSPORT_USES_OLD_API for older image_transport versions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/utils.cpp Switch QoS helper implementation to construct/return rclcpp::QoS.
include/web_video_server/utils.hpp Update QoS helper declaration to return std::optional<rclcpp::QoS>.
src/streamers/ros_compressed_streamer.cpp Adapt compressed-image subscriber QoS creation to the new QoS type.
src/streamers/image_transport_streamer.cpp Use old vs. new image_transport API signatures conditionally and pass QoS appropriately.
CMakeLists.txt Gate old/new image_transport API usage via image_transport_VERSION.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/streamers/image_transport_streamer.cpp Outdated
Comment thread src/utils.cpp Outdated
Comment thread include/web_video_server/utils.hpp Outdated
Comment thread src/streamers/ros_compressed_streamer.cpp Outdated
@bjsowa bjsowa requested a review from MatthijsBurgh July 1, 2026 13:13
@bjsowa bjsowa merged commit 25e753d into ros2 Jul 2, 2026
12 of 16 checks passed
@bjsowa bjsowa deleted the fix/deprecated-api branch July 2, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants