[EPAC-1872]: Add integration tests for /api/v1/members/{id}/speeches handler

[riddim-developer-bot]

Why

The member-speeches handler's pagination math, stats aggregation, and DB query ordering were not exercised against a real schema. Off-by-one paging errors and aggregation bugs could ship silently. This PR adds 6 DB-backed integration tests using the shared `_testdb` harness from EPAC-1869.

What changed

• `backend/member-speeches/main.go` — extract `queryMemberSpeeches(ctx, conn, ...)` so DB logic is directly testable; add `maxPerPage`/`defaultPerPage` constants; fix per-page handling to clamp to 100 (was: silent fallback to default 20)
• `backend/member-speeches/main_integration_test.go` — 6 integration tests calling `queryMemberSpeeches` directly with the `_testdb.WithTx` transactional connection (no `dbConn` override, no Ping path)
• Removed committed Mach-O binary `backend/member-speeches/member-speeches`

Tests implemented

Test	What it covers
`TestMemberSpeechesHappyPath_ReturnsPagedResults`	25 speeches, page 1 of 10: total=25, pages=3, 10 results, IDs ordered newest-first
`TestMemberSpeechesPagination_LastPagePartial`	Same seed, page 3: 5 results, pages=3
`TestMemberSpeechesPagination_PageBeyondLast_ReturnsEmpty`	Page 10 of 25 speeches: 0 results, total still 25
`TestMemberSpeechesUnknownMember_ReturnsEmptyShape`	Unknown member: total=0, pages=0, stats is zero-value object (not null)
`TestMemberSpeechesPerPageBound`	Seeds 150 speeches, calls with per_page=maxPerPage (100): asserts exactly 100 returned
`TestMemberSpeechesStats_AggregatesCorrectly`	6 speeches across 3 dates / 2 topics: TotalSpeeches=6, TopTopic="Bills"

Trade-offs not taken

• Extracted `queryMemberSpeeches` rather than using `dbConn` override — this matches the search handler pattern and avoids relying on pgx Ping behaviour inside an open transaction
• per_page now clamps to 100 (not falls back to 20) for values >100, matching the AC contract and improving UX

Verification

go build -tags=integration ./...   # clean
go test ./...
ok  epac/member-speeches

Integration tests require Postgres sidecar; validated by CI `test-integration` job.

Definition of Done evidence

Flipping `ORDER BY sitting_date DESC` to `ASC` fails `TestMemberSpeechesHappyPath_ReturnsPagedResults` (IDs would be `sp-001..sp-010` instead of `sp-025..sp-016`).

Resolves EPAC-1872

Reviewer-Boundary: review-only

[riddim-reviewer-bot]

ReviewAutonomousPR

• Verdict: request_changes
• Reviewer boundary: review_only
• Acceptance criteria coverage: covered=5, missing=1, unclear=0

Summary

Found blockers: a compiled binary artifact is introduced in the handler module, and the per-page-bound test does not match the stated acceptance criteria around max clamping.

Actionable findings

1. required / required_autonomous_fix — Remove committed build artifact from repository (/Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/member-speeches)
   • backend/member-speeches/member-speeches is a 22MB Mach-O executable added as a tracked file. This is a generated build artifact and should not be committed; it materially bloats the PR and can be accidentally executed in packaging/CI contexts.
   • Actionability: required_autonomous_fix
2. required / required_autonomous_fix — TestMemberSpeechesPerPageBound does not validate the documented max behavior (/Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:159)
   • The acceptance criteria require asserting the handler clamps per_page to its declared max (100). The test currently asserts per_page falls back to default 20 for 999, which codifies the current implementation quirk rather than guarding the AC contract. If the handler regresses to another behavior, this test won’t catch it.
   • Actionability: required_autonomous_fix

Acceptance criteria coverage

• covered — TestMemberSpeechesHappyPath_ReturnsPagedResults — seed 25 speeches..., assert total/pages/len and 10 newest IDs
  • Happy-path pagination assertions for total, pages, length, and descending ID order are present.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:60-88
• covered — TestMemberSpeechesPagination_LastPagePartial — page=3/per_page=10 -> len=5, pages=3
  • Assertion set for both result length and computed pages.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:91-104
• covered — TestMemberSpeechesPagination_PageBeyondLast_ReturnsEmpty — page=10/per_page=10 -> HTTP 200, len=0, total remains real count
  • Status, empty results, and total retention are asserted.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:107-124
• covered — TestMemberSpeechesUnknownMember_ReturnsEmptyShape — unknown member returns HTTP 200, total=0, pages=0, len=0, stats non-nil object
  • Assertions cover status and all required shape fields; stats non-null is checked via response-content guard.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:127-151
• missing — TestMemberSpeechesPerPageBound — verifies declared per_page cap is enforced
  • Test currently verifies fallback-to-default=20 behavior for per_page=999; it does not assert the declared max limit value from the source.
  • Actionability: required_autonomous_fix
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:154-167
  • Suggested follow-up: Align test with explicit max-clamp contract
• covered — TestMemberSpeechesStats_AggregatesCorrectly — seeds 3 dates/2 topics and asserts aggregated stats
  • Test seeds distinct dates/topics and asserts aggregate totals plus top topic result, matching available handler stats surface.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:170-192

Human gate reason

Requesting changes because acceptance criteria are not fully satisfied and a generated executable artifact was added to version control.

[riddim-reviewer-bot]

ReviewAutonomousPR

• Verdict: request_changes
• Reviewer boundary: review_only
• Acceptance criteria coverage: covered=5, missing=1, unclear=0

Summary

The PR is blocked because the per-page boundary test no longer verifies the documented handler contract and can miss regressions in request-time clamping.

Actionable findings

1. required / required_autonomous_fix — Per-page bound test bypasses request parsing and does not assert clamp behavior (/Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:160)
   • TestMemberSpeechesPerPageBound invokes queryMemberSpeeches directly with maxPerPage, so it never exercises the per_page request parsing path that applies clamping in HandleRequest. A regression in clamp behavior (e.g. fallback behavior or changed max) would not be caught. The test should call the handler with per_page=999 (or equivalent) and assert the response/page value is capped at maxPerPage and response length matches that cap.
   • Actionability: required_autonomous_fix

Acceptance criteria coverage

• covered — TestMemberSpeechesHappyPath_ReturnsPagedResults
  • Covers seeding 25 rows, page=1/per_page=10, validates total/pages/len and newest-10 ordering assumption.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:31-58
• covered — TestMemberSpeechesPagination_LastPagePartial
  • Covers last-page partial result and page-count assertions with seeded 25-row dataset.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:61-81
• covered — TestMemberSpeechesPagination_PageBeyondLast_ReturnsEmpty
  • Covers out-of-range page returns with retained total and empty page payload.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:84-103
• covered — TestMemberSpeechesUnknownMember_ReturnsEmptyShape
  • Covers zero-count shape assertions and zero-value stats checks for unknown member.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:106-141
• missing — TestMemberSpeechesPerPageBound
  • The test currently does not invoke HandleRequest with per_page=999; it passes the already-clamped constant into the query helper, so declared max-clamp contract is not validated.
  • Actionability: required_autonomous_fix
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:144-166
  • Suggested follow-up: Rewrite this test to assert per_page clamp through handler request parsing
• covered — TestMemberSpeechesStats_AggregatesCorrectly
  • Validates multi-date/ multi-topic fixture and expected aggregated totals/top topic behavior.
  • Actionability: none
  • Evidence: /Users/sunny/code/epac/.symphony/workspaces/EPAC-1872/backend/member-speeches/main_integration_test.go:169-195

Human gate reason

request_changes because the per-page-bound acceptance criterion is not enforced at the handler/query-contract level, leaving a regression risk in clamping behavior uncaught.