Repository navigation
fix: restore deferred props lost to the bfcache - #5147
Merged
wescopeland merged 2 commits intoAug 4, 2026
Merged
wescopeland merged 2 commits into
wescopeland merged 2 commits into
Conversation
Contributor
Greptile SummaryRestores deferred props after bfcache navigation.
Confidence Score: 5/5The PR appears safe to merge. The global handler safely restores unresolved deferred props only after persisted bfcache restores, replacing narrower component hooks. Reviews (1): Last reviewed commit: "fix: restore deferred props lost to the ..." | Re-trigger Greptile |
Jamiras
approved these changes
Aug 4, 2026
Jamiras
left a comment
Member
There was a problem hiding this comment.
Could not reproduce locally using steps in discord and a random game. Did not introduce any new issues, so willing to give it a pass.
wescopeland
enabled auto-merge (squash)
August 4, 2026 15:23
wescopeland
disabled auto-merge
August 4, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://discord.com/channels/310192285306454017/1523653400158277642/1523653400158277642.
The root cause is similar to something we've repaired before with the game page. It's caused by some parts of the UI being in React and others being in Inertia. A full page nav cancels any deferred props request that's still in-flight. This leads to lost deferred props staying in a loading state indefinitely. Screenshots are loaded via deferred props, which is what's causing the reported behavior.
useReloadDeferredOnBackForwardsolved this problem for a few other game page props. Rather than sprinkling this hook around even more, I've deleted it and lifted the behavior up to a global in our client-side app.tsx:This will keep us from forgetting to re-apply it anytime we use deferred props.