[Runner] Make runner CLI deps optional and gate skill sync by enabled runners#97
Open
sIlENtbuffER wants to merge 1 commit into
Open
[Runner] Make runner CLI deps optional and gate skill sync by enabled runners#97sIlENtbuffER wants to merge 1 commit into
sIlENtbuffER wants to merge 1 commit into
Conversation
…bled runners Move @anthropic-ai/claude-code, @openai/codex, and opencode-ai from dependencies to optionalDependencies so npm install -g does not abort when a runner CLI binary fails to install. Gate sync_global() and sync_quest() behind _is_runner_enabled() checks so the daemon only creates skill directories for enabled runners. Closes ResearAI#96
sIlENtbuffER
force-pushed
the
fix/runner-optional-deps
branch
from
9e366e3 to
fdba47e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@anthropic-ai/claude-code,@openai/codex, andopencode-aifromdependenciestooptionalDependenciessonpm install -gdoes not abort when a runner CLI binary fails to installsync_global()andsync_quest()behind_is_runner_enabled()checks so the daemon only creates skill directories for enabled runnersrunners_configfromDaemonApptoSkillInstallerso it knows which runners are enabledWhy
The published v1.6.0 lists all runner CLIs as required dependencies. Their postinstall scripts download ~100MB platform-specific binaries, and when any fails, the entire install aborts — even for users who only use one runner. Additionally,
sync_global()creates directories for all runners unconditionally, which can crash the daemon if a target directory is unwritable.Closes #96
Test plan
npm pack --dry-run --ignore-scriptssucceeds with the new dependency layoutSkillInstaller._is_runner_enabled()correctly returns true/false based on confignpm install -gfrom the packed tarball succeeds even without runner CLIsds doctorpasses with the changes