Fix coverity tests #583
Open
Fix coverity tests #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: stefanatwork <[email protected]>
svenwoop
requested changes
Jan 29, 2026
| Texture::Texture(Ref<Image> img, const std::string fileName) | ||
| : width(unsigned(img->width)), height(unsigned(img->height)), format(RGBA8), bytesPerTexel(4), width_mask(0), height_mask(0), data(nullptr), fileName(fileName) | ||
| Texture::Texture(Ref<Image> img, std::string &&fileName) | ||
| : width(unsigned(img->width)), height(unsigned(img->height)), format(RGBA8), bytesPerTexel(4), width_mask(0), height_mask(0), data(nullptr), fileName(std::move(fileName)) |
Collaborator
There was a problem hiding this comment.
This here is odd, why would one want to do this? The string object passed would get destroyed by that std::move. This should get reverted.
| { | ||
| AnimatedLightNode (const std::vector<Ref<LightNode>>&& lights, BBox1f time_range) | ||
| : lights(lights), time_range(time_range) {} | ||
| : lights(std::move(lights)), time_range(time_range) {} |
Collaborator
There was a problem hiding this comment.
Also here, semantics to destroy the input vector is odd. Maybe it works, but you would never expect a function you pass a value to destroy the passed object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of commits to address issues flagged by the coverity scan.