Skip to content

Rename Solver, Reduction, and Verifier names - #516

Open
Trosper3 wants to merge 2 commits into
CSharpAPIfrom
rename/solver-reduction-verifier-names
Open

Rename Solver, Reduction, and Verifier names#516
Trosper3 wants to merge 2 commits into
CSharpAPIfrom
rename/solver-reduction-verifier-names

Conversation

@Trosper3

Copy link
Copy Markdown
Contributor

Renamed Solver and Reduction names either reflect ([Problem Name] [Solver/Reduction Type]) or ([Person Who Created Algorithm] Algorithm)

All Verifiers renamed to "Default Verifier"

@Trosper3
Trosper3 requested a review from a team August 31, 2026 23:30
@github-actions

Copy link
Copy Markdown

Redux Build System — CI Report

dotnet · commit 15f7d98

Operation Status Summary Time
audit no known vulnerabilities 4.9s
format-check all files formatted 20.0s
lint 0 issues 31.9s
typecheck ⏭️ covered by lint (dotnet build)
unit-test 907 passed · coverage 70% (min 80%) 38.7s
build built local/redux:ci · 234MB 34.5s
integration-test ⏭️ no [integration] command
push ⏭️ not implemented

Overall: ❌ 4 passed · 1 failed · 3 skipped

@wrigjl

wrigjl commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

When hitting redux with claude (via MCP), it sometimes does not get the name of the solver/verifier/etc class name, but instead, it uses the data that comes back via /info which is for example the human name "Convex Hull Verifier" and then tries to find "Convex Hull Verifier"... which now it won't find.

The matching code matches first by class name and then by the "nice name" (the one with spaces and stuff). If both searches fail, then 404 (or some other error is thrown). One invariant we need to honor is that the "human name" of every verifier, etc is unique.

@wrigjl

wrigjl commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Note: one thing we need here is a unit test that actually tests to ensure this invariant always holds. I believe I did this for Problem already, but verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants