Extract shared InterfaceNavigationData helper for Nav_Solvers/Verifiers/Visualizations - #511
Open
Trosper3 wants to merge 1 commit into
Open
Extract shared InterfaceNavigationData helper for Nav_Solvers/Verifiers/Visualizations#511Trosper3 wants to merge 1 commit into
Trosper3 wants to merge 1 commit into
Conversation
…rs/Verifiers/Visualizations
SolverNavigationData, VerifierNavigationData, and VisualizationNavigationData
each defined their own {className, problemName} entry type and duplicated
the same ~40 lines of Build/Find logic, differing only in which open generic
marker interface (ISolver<>, IVerifier<>, IVisualization<>) and
ProblemProvider dictionary they scanned. Extracts a shared NavigationEntry
type and InterfaceNavigationData.Build/Find/FindWithoutExtension helper
parameterized on the source dictionary and open generic interface type;
each per-kind class is now a thin wrapper. Controller-specific not-found
response shapes (string sentinel vs. empty array) are untouched, per the
issue's explicit direction -- that difference is intentional, not
duplication to fold away.
Closes #462
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolverNavigationData,VerifierNavigationData, andVisualizationNavigationData(inNav_Solvers.cs/Nav_Verifiers.cs/Nav_Visualizations.cs) each independently defined their own{className, problemName}entry type and duplicated the same ~40 lines ofBuild()/Find()logic, differing only in which open generic marker interface (ISolver<>,IVerifier<>,IVisualization<>) andProblemProviderdictionary they scanned.AdditionalControllers/Navigation/InterfaceNavigationData.csadds a sharedNavigationEntrytype andInterfaceNavigationData.Build/Find/FindWithoutExtension, parameterized on the source dictionary and the open generic interface type. Each per-kind class is now a thin 6-line wrapper.Nav_Visualizations.cs) stays controller-specific and untouched.VerifierNavigationData.TryParseProblemKey(not duplicated in the other two files) is preserved as-is.redux-tests/Metadata/ComplexityClass_Tests.csandNav_Batch.csboth consume*NavigationData.Entriesexternally via.className/.problemName— those property names and the static class names are unchanged, only the shared entry type and build logic moved.Closes #462
Test plan
dotnet build --configuration Release(gates ondotnet format --verify-no-changes) — clean, 0 warnings/errors, no reformatting neededdotnet test(full suite) — 898/898 passed, including the external consumers of*NavigationData.Entries