Add instanceFormat/certificateFormat declarations to SUDOKU - #496
Open
Trosper3 wants to merge 3 commits into
Open
Add instanceFormat/certificateFormat declarations to SUDOKU#496Trosper3 wants to merge 3 commits into
Trosper3 wants to merge 3 commits into
Conversation
SUDOKU never adopted the self-describing instance/certificate format pattern (Interfaces/ProblemInterface.cs). Declares instanceFormat describing the semicolon-separated row grammar and certificateFormat describing the fully-filled solution-grid certificate. Format-declaration tests follow the existing DFA/NFA_Tests pattern, plus a check that the certificate example quoted in the format string actually verifies true against defaultInstance (reusing the solved grid that had been sitting commented-out in SUDOKU_Class.cs).
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
Adds named InstanceGrammar const (SUDOKU parses manually rather than via StringParser) and CertificateGrammar/CertificateExample consts on SudokuVerifier, interpolated into instanceFormat/certificateFormat instead of hand-duplicated prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interfaces/ProblemInterface.cs).instanceFormatdescribing the semicolon-separated row grammar andcertificateFormatdescribing the fully-filled solution-grid certificate, onSUDOKU_Class.cs.defaultInstance— reusing the solved grid that had been sitting commented-out inSUDOKU_Class.cs(confirmed it's a genuinely valid solve of the default puzzle).Closes #451
Test plan
dotnet test redux-tests/redux-tests.csproj --filter "FullyQualifiedName~SUDOKU"— 15/15 passing