Add instanceFormat/certificateFormat declarations to PRIMEFACTOR - #491
Open
Trosper3 wants to merge 3 commits into
Open
Add instanceFormat/certificateFormat declarations to PRIMEFACTOR#491Trosper3 wants to merge 3 commits into
Trosper3 wants to merge 3 commits into
Conversation
PRIMEFACTOR never adopted the self-describing instance/certificate format pattern (Interfaces/ProblemInterface.cs). Declares instanceFormat (a single integer) and certificateFormat describing the factor-list certificate, noting the verifier checks only that the factors' product matches the original number (it does not check that each factor is itself prime). Format-declaration tests follow the existing DFA/NFA_Tests pattern, plus a check that the certificate example quoted in the format string actually verifies true against defaultInstance.
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
…attern Extracts the constructor's inline StringParser grammar into a named InstanceGrammar const, and adds CertificateGrammar/CertificateExample consts to PrimeFactorVerifier. instanceFormat/certificateFormat are now interpolated from these plus _defaultInstance, instead of hand-duplicated prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interfaces/ProblemInterface.cs).instanceFormat(a single integer) andcertificateFormatdescribing the factor-list certificate, onPRIMEFACTOR_Class.cs. Notes that the verifier checks only that the factors' product matches the original number — it does not check that each factor is itself prime.(3,5)) actually verifies true againstdefaultInstancevia the real verifier.Closes #446
Test plan
dotnet test redux-tests/redux-tests.csproj --filter "FullyQualifiedName~PRIMEFACTOR"— 20/20 passing