Add instanceFormat/certificateFormat declarations to LOSSLESSDATACOMPRESSION - #487
Open
Trosper3 wants to merge 3 commits into
Open
Add instanceFormat/certificateFormat declarations to LOSSLESSDATACOMPRESSION#487Trosper3 wants to merge 3 commits into
Trosper3 wants to merge 3 commits into
Conversation
…RESSION
LOSSLESSDATACOMPRESSION never adopted the self-describing instance/
certificate format pattern (Interfaces/ProblemInterface.cs). Declares
instanceFormat (free-text input) and certificateFormat describing the
Huffman code-table-plus-bitstring certificate.
The certificateFormat example is illustrative on a short "abc" input
rather than defaultInstance: defaultInstance is a full sentence whose
real Huffman certificate is a ~300-character code table + bitstring,
too unwieldy to serve as a readable format hint. The format-declaration
test documents this and verifies the short example against a
LOSSLESSDATACOMPRESSION("abc") instance instead.
Redux Build System — CI Report
Overall: ❌ 4 passed · 1 failed · 3 skipped |
…tch CLIQUE pattern Adds named InstanceGrammar const (LOSSLESSDATACOMPRESSION parses the raw text input directly, no StringParser) and CertificateGrammar/ CertificateExample consts on LosslessDataCompressionVerifier, interpolated into instanceFormat/certificateFormat instead of hand-duplicated prose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interfaces/ProblemInterface.cs).instanceFormat(free-text input) andcertificateFormatdescribing the Huffman code-table-plus-bitstring certificate, onLOSSLESSDATACOMPRESSION_Class.cs.certificateFormatexample is illustrative on a short"abc"input rather thandefaultInstance—defaultInstanceis a full sentence whose real Huffman certificate is a ~300-character code table + bitstring, too unwieldy to serve as a readable format hint (this field is quoted back to callers on parse errors). The format-declaration test documents this and verifies the short example against aLOSSLESSDATACOMPRESSION("abc")instance instead, using the exact(97=0;98=10;99=11) encoded:01011certificate already proven correct in the existing test file.Closes #442
Test plan
dotnet test redux-tests/redux-tests.csproj --filter "FullyQualifiedName~LOSSLESSDATACOMPRESSION"— 14/14 passing