fix a @scadenziario issue with recurrences - #323
Merged
Conversation
Coverage Report for CI Build 29396749534Coverage increased (+0.04%) to 69.924%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cekk
self-requested a review
July 15, 2026 07:19
cekk
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an event span multiple days and has a recurrence pattern (for example only Monday and Friday), plone.event inserts by default the first day of the event, even if it does not match the recurrence.
Example:
Event from 2 to 17 july, only monday and friday.
@scadenziario returns 2 (Thusday), 3 (Friday), 6 (Monday), 10 (Friday), 13 (Monday), 17 (Friday)
The 2 is incorrect, and this pull request fixes it. The behavior of plone.event is correct in itself because is compliant with the RFC5545 that implements.