Skip to content

fix a @scadenziario issue with recurrences - #323

Merged
fedevancin merged 2 commits into
mainfrom
remove_first_occurrence
Jul 15, 2026
Merged

fix a @scadenziario issue with recurrences#323
fedevancin merged 2 commits into
mainfrom
remove_first_occurrence

Conversation

@fedevancin

Copy link
Copy Markdown
Contributor

When an event span multiple days and has a recurrence pattern (for example only Monday and Friday), plone.event inserts by default the first day of the event, even if it does not match the recurrence.

Example:
Event from 2 to 17 july, only monday and friday.
@scadenziario returns 2 (Thusday), 3 (Friday), 6 (Monday), 10 (Friday), 13 (Monday), 17 (Friday)

The 2 is incorrect, and this pull request fixes it. The behavior of plone.event is correct in itself because is compliant with the RFC5545 that implements.

@fedevancin
fedevancin requested a review from cekk July 14, 2026 14:27
@fedevancin fedevancin self-assigned this Jul 14, 2026
@coveralls

coveralls commented Jul 14, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29396749534

Coverage increased (+0.04%) to 69.924%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 3 uncovered changes across 1 file (13 of 16 lines covered, 81.25%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/design/plone/contenttypes/restapi/services/scadenziario/post.py 16 13 81.25%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4974
Covered Lines: 3478
Line Coverage: 69.92%
Coverage Strength: 0.7 hits per line

💛 - Coveralls

@cekk cekk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test?

@cekk
cekk self-requested a review July 15, 2026 07:19
@fedevancin
fedevancin merged commit 2ae46a5 into main Jul 15, 2026
10 checks passed
@fedevancin
fedevancin deleted the remove_first_occurrence branch July 15, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants