Skip to content

fix: add group when cutting workspace comments #9680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lizschwab wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

fix: add group when cutting workspace comments #9680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee8ab9f
fix: add group when cutting workspace comments
Apr 3, 2026
a85ed4d
Update shortcut_items.ts
Apr 6, 2026
556b865
added check for group to the cut workspace comment unit test
Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/blockly/core/shortcut_items.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ export function registerCut() {
if (focused instanceof BlockSvg) {
focused.checkAndDelete();
} else if (isIDeletable(focused)) {
eventUtils.setGroup(true);
focused.dispose();
eventUtils.setGroup(false);
}
return !!copyData;
},
Expand Down
5 changes: 5 additions & 0 deletions packages/blockly/tests/mocha/shortcut_items_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,11 @@ suite('Keyboard Shortcut Items', function () {
this.disposeSpy = sinon.spy(this.comment, 'dispose');

this.injectionDiv.dispatchEvent(keyEvent);

const deleteEvents = this.workspace
.getUndoStack()
.filter((e) => e.type === 'comment_delete');
assert(deleteEvents[0].group !== ''); // Group string is not empty
sinon.assert.calledOnce(this.copySpy);
sinon.assert.calledOnce(this.disposeSpy);
});
Expand Down