feat: Move mode for stacks of blocks#9630
Merged
mikeharv merged 5 commits intoRaspberryPiFoundation:v13from Mar 16, 2026
Merged
feat: Move mode for stacks of blocks#9630mikeharv merged 5 commits intoRaspberryPiFoundation:v13from
mikeharv merged 5 commits intoRaspberryPiFoundation:v13from
Conversation
gonfunko
approved these changes
Mar 12, 2026
Contributor
gonfunko
left a comment
gonfunko
left a comment
There was a problem hiding this comment.
Just a couple minor nits but otherwise looks good, thanks!
| suite('to disconnect blocks', function () { | ||
| setup(function () { | ||
| // Clear workspace and build 3-block stack. | ||
| this.workspace.clear(); |
Contributor
There was a problem hiding this comment.
The workspace should have been set up afresh before each test, the clearing shouldn't be necessary.
| test('from bottom block - Detaches single block', function () { | ||
| Blockly.getFocusManager().focusNode(this.block3); | ||
| startMove(this.workspace); | ||
| assert.isNull(this.block3.nextConnection.targetBlock()); |
Contributor
There was a problem hiding this comment.
The previous connection is more relevant to verify here since it was already the last block in the stack
| test('from bottom block - Detaches single-block stack from bottom', function () { | ||
| Blockly.getFocusManager().focusNode(this.block3); | ||
| startMoveStack(this.workspace); | ||
| assert.isNull(this.block3.nextConnection.targetBlock()); |
Contributor
There was a problem hiding this comment.
As with the single block case I'd check previousConnection here
Contributor
Author
There was a problem hiding this comment.
Good idea. I also added a previousConnection check for block2 for each of the "middle block" tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes first part of #9625
Proposed Changes
Adds a new shortcut to enable move mode with Shift+M. Updates block drag strategy so that keyboard events including shift will move the full stack of blocks (similar to a normal pointer drag).
Reason for Changes
Shift+M should activate move mode for the focused block and its children (the same set of blocks that would be moved if you use the mouse)
Test Coverage
Add new tests to check that disconnecting blocks works as expected when turning on move mode. We check each of three blocks in a stack using both the standard and modified shortcut.
Documentation
Additional Information