refactor!: Deprecate Block.getVars()
#9574
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1498
Proposed Changes
This PR deprecates
Block.getVars()in favor ofBlock.getVarModels(), and removes@internalfrom the latter. This method is more flexible as it returns the entire variable model objects rather than just their IDs (or, in the case of procedure blocks, their names).renameVarmentioned in the bug was removed long ago.Breaking Changes
If you are calling
Block.getVars(), you should callBlock.getVarModels()instead. To get just the IDs,Block.getVarModels().map(model => model.getId())should be identical to the old behavior.