Skip to content

Let a left-edge swipe reveal the timeline over an article #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dave-atx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Let a left-edge swipe reveal the timeline over an article #5506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions iOS/Article/ArticleViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,11 +576,13 @@ extension ArticleViewController: UIGestureRecognizerDelegate {
}

func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer) -> Bool {
let point = gestureRecognizer.location(in: nil)
if point.x > 40 {
// Paging is the only thing to hold back near the left edge. Refusing every other
// recognizer there also blocked the split view's reveal gesture, so an edge swipe
// did nothing over the article while it still worked alongside the toolbars.
guard otherGestureRecognizer === pageViewController.scrollViewInsidePageControl?.panGestureRecognizer else {
return true
}
return false
return gestureRecognizer.location(in: nil).x > 40
}

}
Expand Down
Loading