fix exception: uninitialized constant#100
Merged
andrzejkrzywda merged 1 commit intoRailsEventStore:masterfrom Feb 23, 2022
Merged
fix exception: uninitialized constant#100andrzejkrzywda merged 1 commit intoRailsEventStore:masterfrom
andrzejkrzywda merged 1 commit intoRailsEventStore:masterfrom
Conversation
When posted wrong vat code: NameError (uninitialized constant Invoicing::Product::VatRateNotApplicable) But still not working because of https://github.com/RailsEventStore/ecommerce/blob/master/rails_application/app/controllers/products_controller.rb#L45 and exception: [Infra::Types::VatRate.new] :code is missing in Hash input ;)
Contributor
|
thanks! what would be the best test to cover this? |
Contributor
Author
|
But problem is with https://github.com/RailsEventStore/ecommerce/blob/master/rails_application/app/controllers/products_controller.rb#L45 If you'll add condition to getting vat rate in controller, then an exception from domain will never occur. ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When posted wrong vat code: NameError (uninitialized constant Invoicing::Product::VatRateNotApplicable)
But still not working because of https://github.com/RailsEventStore/ecommerce/blob/master/rails_application/app/controllers/products_controller.rb#L45 and exception: [Infra::Types::VatRate.new] :code is missing in Hash input
;)