Validate query uses capabilities from blockchain config, not candidate block#30
Merged
bvscd merged 14 commits intorelease/node/v0.4.0from Mar 25, 2026
Merged
Conversation
ci: add Rust CI workflow
There was a problem hiding this comment.
Pull request overview
Updates validator transaction checking to rely on the network configuration’s global version/capabilities (from ConfigParams) rather than the optional per-block gen_software() field, and bumps the node crate version.
Changes:
- Use
base.config_params.global_version()andbase.config_params.capabilities()when constructingBlockchainConfigfor transaction validation. - Bump
src/nodecrate version from0.3.0to0.4.0(and updateCargo.lockaccordingly).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/node/src/validator/validate_query.rs |
Builds BlockchainConfig for transaction validation using values from config params (authoritative network config). |
src/node/Cargo.toml |
Increments the node crate version to 0.4.0. |
src/Cargo.lock |
Updates lockfile entry for the node package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bvscd
changed the title
yaroslavser
changed the title
bvscd
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #28