ci: trigger workflows on rocprofiler-systems branch#36
Closed
adjordje-amd wants to merge 3 commits intorocprofiler-systemsfrom
Closed
ci: trigger workflows on rocprofiler-systems branch#36adjordje-amd wants to merge 3 commits intorocprofiler-systemsfrom
adjordje-amd wants to merge 3 commits intorocprofiler-systemsfrom
Conversation
adjordje-amd
force-pushed
the
users/adjordje-amd/ci-add-rocprofsys-trigger
branch
from
bd7ab63 to
e1602c4
Compare
Add rocprofiler-systems to push/pull_request trigger lists in continuous-integration, formatting, and python-package workflows. Drop the obsolete omnitrace branch (renamed to rocprofiler-systems). Currently only master, develop, and the legacy omnitrace branch trigger CI. rocprofiler-systems is the active consumer-facing branch for the ROCm/rocm-systems superproject; PRs targeting it should run the same checks. Drive-by fixes uncovered by enabling the trigger: - python-package.yml: bump matrix from Python 3.7/3.8/3.9 to 3.10/3.11/3.12. The older versions no longer ship pre-built setup-python wheels for ubuntu-latest (Ubuntu 24.04). - continuous-integration.yml: include 'pip' in the conda env create command. Recent conda-forge python distributions do not ship pip by default, breaking the subsequent 'python -m pip install -r requirements.txt' step.
adjordje-amd
force-pushed
the
users/adjordje-amd/ci-add-rocprofsys-trigger
branch
from
e1602c4 to
fbd8aa5
Compare
flake8 added the F824 check (unused 'global' declaration where the name is never assigned in the scope). Seven pre-existing occurrences across setup.py, plotting.py, profiler.py, __main__.py, tracer.py were silent under older flake8 but now break the linting workflow on Python 3.10/3.11/3.12. Drop the dead declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The rocprofiler-systems branch is the active consumer-facing branch for the ROCm/rocm-systems superproject, but the existing CI workflows do not include it in their push / pull_request triggers. PRs targeting rocprofiler-systems currently land without any automated checks running.
The omnitrace branch (the previous name for what is now rocprofiler-systems) is still in the trigger lists. Drop it.
Technical Details
.github/workflows/continuous-integration.yml(push + pull_request).github/workflows/formatting.yml(push + pull_request).github/workflows/python-package.yml(push + pull_request)Replace
omnitracewithrocprofiler-systemsin each trigger list.release.ymlis tag-driven, no change.Test Plan
This PR itself targets
rocprofiler-systems. If the workflows fire on it, the change is verified end-to-end.Test Result
To be observed on this PR.
Submission Checklist