[CK TILE] Refactor sequence_reverse_inclusive_scan #3609
+745
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CongMa13
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
Contributor
|
Thanks! Could you also measure the build metrics improvements, e.g. number of templates instantiated, or wall time improvement for some target? |
tenpercent
reviewed
Jan 20, 2026
| template <index_t I, index_t... Is, typename Reduce, index_t Init> | ||
| struct sequence_reverse_inclusive_scan<sequence<I, Is...>, Reduce, Init> | ||
| template <index_t... Is, typename Reduce, index_t Init> | ||
| struct sequence_reverse_inclusive_scan_impl<sequence<Is...>, Reduce, Init> |
Contributor
There was a problem hiding this comment.
re: implementation, would it help to have separate compile-time functions for sequence reversal (constexpr function with c-array initialized with variadic indices and then reverse using a for-loop logic) and scan (with a similar structure)?
- Add trivial_array for template programming - Add unit tests of sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactor ck tile
sequence_reverse_inclusive_scanfrom recursive to for-loop.Tracking issue: #3575