test: preserve default ROCm backend behavior#488
Merged
Conversation
6e580c2 to
dafdfc8
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
dafdfc8 to
f0869a2
Compare
coderfeli
approved these changes
May 9, 2026
Collaborator
|
LGTM. Merged @Peter9606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds guardrail tests for FlyDSL’s multi-backend defaults.
The tests ensure that:
rocmrocmrocdlbackendrocdlis selectedMotivation
FlyDSL now has infrastructure for multiple hardware backends. As new backend stacks are added, community users who do not opt into those backends should see no behavior change: default imports, backend selection, runtime pairing, tests, and builds should continue to use the existing ROCm/ROCDL path.
This PR makes that invariant explicit without adding any vendor-specific backend. The CMake test uses a temporary
dummybackend descriptor to verify that future backend descriptors remain opt-in.Test plan
PYTHONPATH="$PWD/python:$PWD" python3 -m pytest \ tests/unit/test_device_runtime.py \ tests/unit/test_compile_backends.py \ tests/unit/test_backend_cmake_defaults.py \ -v --confcutdir=tests/unitResult: 15 passed.