Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
HomeServiceto aggregate tags from both tasks and notes, rather than just tasks. It also improves the logic for handling untagged items and updates the constructor and related tests to support the new dependency.Enhancements to tag aggregation:
HomeServiceto collect tags from both tasks and notes, ensuring the "untagged" label is included if any item lacks a tag.Dependency and test updates:
HomeServiceto accept aNoteServicedependency in its constructor, updating the class to support note-related operations. [1] [2]HomeServiceTestsetup to use the new constructor signature withNoteService.