Skip to content

Add brk_parser to similar projects#98

Merged
RCasatta merged 1 commit intoRCasatta:masterfrom
nym21:master
Apr 15, 2025
Merged

Add brk_parser to similar projects#98
RCasatta merged 1 commit intoRCasatta:masterfrom
nym21:master

Conversation

@nym21
Copy link
Contributor

@nym21 nym21 commented Apr 15, 2025

Tried to be as objective as possible, please tell me if you'd prefer some edits

@RCasatta
Copy link
Owner

It's fine, the only doubt I have is that in your benchmark table the time result for blocks iterator is with computing the UTXO active or not

@RCasatta RCasatta merged commit 85c82b4 into RCasatta:master Apr 15, 2025
9 of 10 checks passed
@nym21
Copy link
Contributor Author

nym21 commented Apr 15, 2025

Thank you for merging

It's been a while but I'm fairly certain that it was tested with the example in the README so something like this

let conf = blocks_iterator::Config::new("../blocks", bitcoin::Network::Bitcoin);
for b in blocks_iterator::iter(conf) {
  // Something very simple
}

I'm trying with skip_prevout = true see how it goes

I was wondering was nothing was happening for a long time and remembered that I'm using a XORed chain. It will take a while to retest this

@RCasatta
Copy link
Owner

Yeah without additional configuration the default is to provide previous outputs, which is very expensive to compute because you have to track the UTXO set and thus it's taking much more.

On my machine it's about 10 minutes without previous outputs.

@nym21
Copy link
Contributor Author

nym21 commented Apr 15, 2025

That's indeed quite the difference then, sorry about that ! I'll update the README to reflect this

EDIT: bitcoinresearchkit/brk@e604464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants