saving output from different ranks #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forklady42
requested changes
Jan 21, 2026
| for ind, err in zip(index, nmae.tolist(), strict=False): | ||
| f.write(f"{ind},{err}\n") | ||
| # write final CSV with header | ||
| with open(final_csv, "w") as f_out: |
Collaborator
There was a problem hiding this comment.
Currently, all nodes will try to write to this file, which can cause issues. Let's change this to add torch.distributed.barrier() to synchronize the processes and only let rank==0 write the final_csv.
| if self.log_dir is not None: | ||
| self.log_dir = Path(self.log_dir) | ||
| self.log_dir.mkdir(exist_ok=True, parents=True) | ||
| self.tmp_dir = Path(self.out_dir) / "tmp" |
Collaborator
There was a problem hiding this comment.
self.out_dir could be None here. Should this be in the previous block?
| nmae = nmae.unsqueeze(0) | ||
| tmp_csv = self.tmp_dir / f"metrics_batch_{self.global_rank}_{batch_idx}.csv" | ||
| with open(tmp_csv, "w") as f: | ||
| for i, n in zip(indices, nmae, strict=False): |
Collaborator
There was a problem hiding this comment.
Strongly prefer strict=True unless there is a reason we do not expect the dimensions to match.
| for tmp_csv in all_tmp_csvs: | ||
| with open(tmp_csv) as f_in: | ||
| for line in f_in: | ||
| f_out.write(line) |
Collaborator
There was a problem hiding this comment.
Would be nice to clean up the tmp_dir files once this is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles logging/saving the performance metric across multiple ranks.