Skip to content

Conversation

@blnicho
Copy link
Member

@blnicho blnicho commented Dec 12, 2025

Summary/Motivation:

A new version of platformdirs (4.5.1) is causing the win/3.13 GHA job to fail again. This is a continuation of the issue noted in #3770. This PR makes the pin on platformdirs more strict. This PR also includes the changes from #3805.

Changes proposed in this PR:

  • Exclude platformdirs 4.5.1 and pip 25.3 on win GHA jobs
  • Remove temporary pin on Python 3.14 version

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.21%. Comparing base (a079b25) to head (db32bf0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3799      +/-   ##
==========================================
- Coverage   89.41%   88.21%   -1.21%     
==========================================
  Files         909      909              
  Lines      105579   105579              
==========================================
- Hits        94407    93137    -1270     
- Misses      11172    12442    +1270     
Flag Coverage Δ
builders 29.10% <ø> (-0.02%) ⬇️
default 86.04% <ø> (?)
expensive 35.76% <ø> (?)
linux 83.61% <ø> (-5.57%) ⬇️
linux_other 83.61% <ø> (-3.12%) ⬇️
osx 82.88% <ø> (ø)
win 81.21% <ø> (-3.77%) ⬇️
win_other 81.21% <ø> (-3.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blnicho blnicho changed the title Add stricter pin on platformdirs in GHA win jobs Exclude platformdirs 4.5.1 in GHA win jobs Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants