Remove unused thermocycler backend methods#1097
Open
codewithdaniel1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses issue #637, which notes that several thermocycler backend methods do not need to be backend commands because the values can be retrieved from protocol stage/step data or cached from the running protocol.
Keeping these methods on
ThermocyclerBackendmakes each concrete backend responsible for commands that are not actually backend-specific. This cleanup simplifies the backend interface while preserving useful high-levelThermocyclerbehavior.Closes #637
What Changed
Removed these unused methods from
ThermocyclerBackendand concrete backend implementations:get_block_target_temperatureget_lid_target_temperatureget_total_cycle_countget_total_step_countUpdated the high-level
Thermocyclerwrapper so target temperatures and protocol counts are tracked through wrapper state instead of requiring each backend to expose those values as backend commands.Updated related tests so they no longer expect deleted backend methods.
Before / After Evidence
Before:
After:
Acceptance Criteria
Thermocyclerbehaviorgit diff --checkTesting
Result:
Additional check:
Result: no output.