Allow alias To: address in the event attendee list#447
Draft
dinvlad wants to merge 10000 commits intoProtonMail:mainfrom
Draft
Allow alias To: address in the event attendee list#447dinvlad wants to merge 10000 commits intoProtonMail:mainfrom
dinvlad wants to merge 10000 commits intoProtonMail:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
I'm trying to address a long-standing issue when the email address used in the To: header is one of alias addresses (such as those in SimpleLogin), but the attendee list in event invitation email is checked only against the list of Proton mail addresses.
As a result, currently the user sees
Your email address is not in the original participants list.warning, instead ofAdd to Proton Calendarbutton. This is frustrating for many users who have been using SimpleLogin aliases, as we have to then go through many clicks in Calendar app settings to import the event from the .ics file:https://protonmail.uservoice.com/forums/284483-proton-mail/suggestions/45483934-allow-adding-a-calendar-invite-to-proton-calendar
This PR aims to address this issue by comparing
To:field with the attendee list, in addition to existing logic for comparing attendees. Please let me know if you approve of the general idea, and I'll comb through the tests a bit more.Thanks!