Skip to content

keep shutdown and replaced close errors visible - #3339

Merged
snimu merged 14 commits into
mainfrom
lane/perf-close-arms-errorrow-fast
Oct 6, 2026
Merged

snimu merged 14 commits into
mainfrom
lane/perf-close-arms-errorrow-fast

Conversation

@kevinjosethomas

@kevinjosethomas kevinjosethomas commented Oct 3, 2026 •

Copy link
Copy Markdown
Member
  • bare shutdown and replaced closes now show a persistent error row with the real explanation instead of a generic session-closed note.
  • the close explanation survives the session ending, matching the ts behavior.

@kevinjosethomas kevinjosethomas changed the title fix(tui): keep shutdown and replaced close errors visible keep shutdown and replaced close errors visible Oct 5, 2026
…orrow-fast

# Conflicts:
#	crates/pa-cli/tests/interactive_daemon_e2e.rs
#	crates/pa-tui/src/session_ui/apply.rs

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 774c943. Configure here.

Comment thread crates/pa-tui/src/session_ui/apply.rs
…base flake tui_prime_login_renders_the_inline_team_picker (flaky clipboard_auth_commands_e2e login settle, 60s settle timeout, pre-existing on main; registered per audit with census run 36935920856; also hit PR #3287 shard 5/8 run 36950742559 with zero diff intersection - pa-daemon-only PR, separate test binary; this PR's 2-file diff - pa-tui apply.rs close rows + interactive_daemon_e2e close oracle - has zero clipboard/login intersection; same tree as 774c943, empty commit)
…act-upload API timeout, not a test failure (Failed to CreateArtifact: Request timeout ArtifactService/CreateArtifact after 5 attempts; every shard-2 unit in the job log is green, zero FAILED test results; the manifest artifact never landed so the test-summary partition audit reported 'shard 2: no manifest'; same ci-harness bookkeeping family as the registered zero-failing-tests partition-audit class; this PR's 2-file diff is unchanged; same tree as bfa3a9b, empty commit)
@snimu
snimu merged commit 19808d0 into main Oct 6, 2026
27 checks passed
@snimu
snimu deleted the lane/perf-close-arms-errorrow-fast branch October 6, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants