Fix: The Db is dropped even when the PS_ERASE_DB is set to 0#451
Fix: The Db is dropped even when the PS_ERASE_DB is set to 0#451PululuK wants to merge 2 commits intoPrestaShop:masterfrom
Conversation
nicosomb
changed the title
Co-authored-by: Nicolas Lœuillet <nicolas@loeuillet.org>
|
Hello @Quetzacoalt91 |
|
Hello @PululuK, Can you please describe what was the issue you're trying to solve? |
PululuK
changed the title
oh sorry I just updated |
| echo "\n* Drop mysql database..."; | ||
| echo "\n* Dropping existing database $DB_NAME..." | ||
| mysql -h $DB_SERVER -P $DB_PORT -u $DB_USER -p$DB_PASSWD -e "drop database if exists $DB_NAME;" | ||
| fi |
There was a problem hiding this comment.
This code was useful even if we did not trigger the auto installation of PrestaShop. Don't you think the parameter --db_clear=$PS_ERASE_DB would be enough here?
There was a problem hiding this comment.
@Quetzacoalt91 if you don't need to use the auto installation, in this case you need to adapte your script using post-install-scripts
tleon
left a comment
tleon
left a comment
There was a problem hiding this comment.
Shouldn't you regenerate the base images so they implement your change ?
SharakPL
changed the title
7 participants
PS_ERASE_DBis setted 0DBis droped only whenPS_ERASE_DBis 0