style: изменить стиль кода#42
Open
TimoshenkoAleksey wants to merge 3 commits intoPraktikumJava:masterfrom
Open
style: изменить стиль кода#42TimoshenkoAleksey wants to merge 3 commits intoPraktikumJava:masterfrom
TimoshenkoAleksey wants to merge 3 commits intoPraktikumJava:masterfrom
Conversation
DvoeglazovAleksey
suggested changes
Dec 14, 2022
DvoeglazovAleksey
left a comment
DvoeglazovAleksey
left a comment
There was a problem hiding this comment.
Отличная работа, возможно нужны уточнения не большие.
|
|
||
| public class DepositCalculator { | ||
|
|
||
| double calculateComplexPercent(double startDeposit, double yearRate, int depositPeriod) { |
There was a problem hiding this comment.
public не требуется. Отлично!
| return roundFinalDeposit(pay, 2); | ||
| } | ||
|
|
||
| double calculateSimplePercent(double startDeposit, double yearRate, int depositPeriod) { |
There was a problem hiding this comment.
Понятное название метода-отлично!
| double finalDeposit = 0; | ||
| if (depositType == 1) { | ||
| finalDeposit = calculateSimplePercent(startDeposit, 0.06, depositPeriod); | ||
| } else if (depositType == 2) { |
There was a problem hiding this comment.
else if без выравнивания , возможно можно лучше.
| } else if (depositType == 2) { | ||
| finalDeposit = calculateComplexPercent(startDeposit, 0.06, depositPeriod); | ||
| } | ||
| System.out.println("Результат вклада: " + startDeposit + " за " + depositPeriod + " лет превратятся в " |
There was a problem hiding this comment.
Перенос метода на новую строку не требуется если не превышает размер 120 символов.
| public static void main(String[] args) { | ||
| new DepositCalculator().calculationDepositInterest(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.