refactor: replace duplicate escapeHtml in markdown.ts with shared import from toolIconResolver#457
Merged
Power-Maverick merged 2 commits intofeat/whats-newfrom Mar 16, 2026
Merged
Conversation
5 tasks
…ing it in markdown.ts Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on 'What's New' feature implementation
refactor: replace duplicate escapeHtml in markdown.ts with shared import from toolIconResolver
Mar 16, 2026
Power-Maverick
approved these changes
Mar 16, 2026
Power-Maverick
added a commit
that referenced
this pull request
Mar 16, 2026
* feat: implement "What's New" feature with auto-update notifications and markdown rendering * feat: enhance "What's New" feature to support insider version detection and update URLs accordingly * Fix: Inject PPTB_UPDATES_ORIGIN into renderer CSP at build time (#454) * Initial plan * fix: make CSP reflect configured PPTB_UPDATES_ORIGIN at build time via Vite transformIndexHtml Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Power-Maverick <36135520+Power-Maverick@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * refactor: replace duplicate escapeHtml in markdown.ts with shared import from toolIconResolver (#457) --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdown.tsdefined its ownescapeHtmlthat was byte-for-byte identical to the one already exported fromtoolIconResolver.ts, creating a silent divergence risk for sanitization logic.src/renderer/utils/markdown.ts— removed localescapeHtmldefinition; replaced withimport { escapeHtml } from "./toolIconResolver". No behavior change.Use a meaningful title for the pull request.
Follow the guidelines from the CONTRIBUTING.md.
Mention the bug or the feature number the PR will be targeting.
Test the change in your own code. (Compile and run)
Resolve all GH Copilot comments.
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.