fix(inbox): show only ready PRs in the pull requests tab#64585
Merged
Conversation
Contributor
|
Hey @Twixes! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
Contributor
|
Reviews (1): Last reviewed commit: "Show only ready PRs in the inbox Pull re..." | Re-trigger Greptile |
Contributor
|
Size Change: 0 B Total Size: 64.4 MB ℹ️ View Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Reviews (2): Last reviewed commit: "Update reportListLogic.ts" | Re-trigger Greptile |
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
The Pull requests tab sent only `has_implementation_pr=true`, so the backend returned PRs of every non-suppressed status. Merged/closed (`resolved`) PRs piled up in the list and inflated the count chip — e.g. 4 PRs shown when only 1 was actually awaiting review. Add `status: 'ready'` to the pulls tab's fixed params so the list and its count (which share the same params) show only PRs awaiting review. Generated-By: PostHog Code Task-Id: a6430aac-4a87-4443-841e-fb96961a6832
Twixes
force-pushed
the
posthog-code/inbox-pulls-ready-only
branch
from
f9e63ef to
b98fe91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inbox Pull requests tab sent only
has_implementation_pr=true, so the backend returned PRs of every non-suppressed status. Merged/closed (resolved) PRs piled up in the list and inflated the tab's count chip with work that's already done — a user saw 4 PRs when only 1 was actually awaiting review.Changes
Add
status: 'ready'to the pulls tab's fixed params (INBOX_FLAT_TAB_LIST_PARAMS.pulls). The list and its count chip share these params, so both now show onlyreadyPRs (a draft awaiting review). Resolved/merged PRs drop off.How did you test this code?
I'm an agent (PostHog Code). This is a one-line change to a fixed filter param; no Cloud tests reference
INBOX_FLAT_TAB_LIST_PARAMS. The matching change in the PostHog Code desktop app (PostHog/code#2758) carries unit tests for the equivalentready-only PR membership rule, which pass.Automatic notifications
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Directed from a PostHog Slack thread where the inbox PR count differed between Cloud and the Code desktop app. Investigation found the difference was
resolvedPRs: the Code app hid them, Cloud showed them. The agreed direction was that neither should surface done work — the Pull requests tab should show and count onlyreadyPRs. This PR makes that change in Cloud; PostHog/code#2758 makes the matching change in the desktop app (superseding an earlier PR that had aligned the wrong way).Built with PostHog Code (Claude Opus).
Created with PostHog Code from a Slack thread