Align with HeroUI 3.2.5 and show focus rings only for keyboard input - #10
Merged
Merged
Conversation
…only Upgrade the parity baseline and ship Tag's 24px remove target, Tabs alignment, Select clear, and toast.update. Focus rings now appear only after keyboard controls, never after pointer open/close or Escape. Co-authored-by: Cursor <cursoragent@cursor.com>
The queue now expands on hover/focus or isExpanded, holds exiting cards, and Toast::promise updates the loading card in place when the future settles. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Select keeps both the clear-button composition from this branch and master's typed theme defaults: the recipe/variant resolution runs after the clear-selection closure is seeded, borrowing the cloned theme colors the clear path already moved into its closures. llms.txt keeps the code-accurate `selected_keys()` wording, adding master's `recipe()` and compact-parts rows. The committed wasm artifact is rebuilt from the merged sources with its parity manifests, and the redundant clone clippy flagged in focus_visible_deep is dropped. Co-Authored-By: Claude Code <noreply@anthropic.com>
The parity audit flagged two constant element ids in ToastViewport::render. The hotkey interceptor's keyed state was a hard-wired name, ignoring the caller-supplied viewport id, so two named viewports on one screen shared one interceptor slot; scope it to the region id like the pointer and focus parts already are. The remaining 'toast-region' constant is the fallback seed for the viewport's own .id(..)-overridable id -- the same shape the audit's 'modal' entry allows -- so record it in CONSTANT_ALLOWED with that rationale. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins HeroGPUI to the HeroUI v3.2.5 contract and brings component behavior, audits, gallery, and site data in line with that release.
.shots/test_bundle.pyand digest-keyed CSS cache handling in.shots/bundle.py.util::shows_focus_ringacross pickers, calendars, list rows, inputs, and related helpers so pointer focus does not draw a ring; addfocus_visible_deep.rscoverage.toast_stack_deep.rs,toast_promise_deep.rs, andtoast_update_deep.rs.select_clear_deep.rs), tab list alignment (tabs.rs/tabs_deep.rs), and tag remove-button layout (tag_group.rs/tag_geometry_deep.rs); record upstream/port evidence underdocs/parity/evidence/.llms.txt, regeneratedreference.json/rust-examples.json/ wasm manifests, rebuilt wasm gallery artifacts, and pinnedreact-aria/react-aria-componentsversions inweb/package.json.docs/parity/audit-results.json,interaction-inventory.json,interaction-sweep.md, and scoped evidence READMEs for the select-clear, tabs-align, and tag-remove sweeps.