Repository navigation
fix(ios): keep bottom triggers clear of the tab bar when it changes - #35
Merged
onurhanavci merged 2 commits intoOct 27, 2026
Merged
onurhanavci merged 2 commits into
onurhanavci merged 2 commits into
Conversation
#34 measured the host tab bar once, when the trigger was built, so a trigger that stayed up didn't follow the bar hiding (hidesBottomBarWhenPushed), coming back, or changing height on rotation. The overlay manager now keeps the bottom constraint and measures the bar again on the reuse path (after any host transition in flight finishes), when the overlay window changes size, and when the widget sheet closes. A new constant also marks the layout stale; without it the next layout pass kept the old position.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic adjustment of the bottom clearance for bottom-docked triggers in PoltioOverlayManager to ensure they correctly clear the host tab bar during rotations, screen transitions, or when the tab bar is hidden/shown. It also adds corresponding unit tests. The review feedback points out a potential issue where coordinator.animate(alongsideTransition:completion:) might return false if the transition is not animated or has already finished, which would prevent the clearance refresh logic from executing. It is recommended to handle this fallback case to guarantee the layout is always updated.
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #34. Follow-up from the #34 review: the host tab bar was measured once, when the trigger was built.
hidesBottomBarWhenPushed, finishes), on overlay size changes (rotation), and when the widget sheet closesTest: example app, Shop tab: the card sits 70pt above the tab bar in portrait and in landscape (measured 70.0 / 70.3pt; the stale value left ~76pt in landscape).