Add ui-kit Header and Footer components#172
Open
SakshiKekre wants to merge 2 commits intoPolicyEngine:mainfrom
Open
Add ui-kit Header and Footer components#172SakshiKekre wants to merge 2 commits intoPolicyEngine:mainfrom
SakshiKekre wants to merge 2 commits intoPolicyEngine:mainfrom
Conversation
SakshiKekre
force-pushed
the
feat/uikit-header-footer
branch
from
96877a4 to
cf06d18
Compare
- Add PolicyEngineHeader component matching policyengine.org production header (nav: Research, Model, API, About dropdown with Team/Supporters/Citations, Donate) - Uses tracker's designTokens instead of hardcoded colors - Replace old white title+logo header with PE teal gradient header + title sub-bar - Update favicon to absolute URL (policyengine.org hosted asset) - Update chart export watermark to absolute URL Temporary: hand-rolled header until ui-kit 0.4.0 is published (see TODO in file).
- Add PolicyEngineFooter component matching policyengine.org production footer (logo, nav links, social icons, subscribe form, copyright) - Uses tracker's designTokens instead of hardcoded colors - Remove old dark footer bar and unused FooterLink component Separate commit for easy revert if needed. Temporary: hand-rolled footer until ui-kit 0.4.0 is published (see TODO in file).
SakshiKekre
force-pushed
the
feat/uikit-header-footer
branch
from
cf06d18 to
2a5cd4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds PE org header and footer to the state legislative tracker, matching policyengine.org production.
app-v2 PR #914 (already merged) switched the tracker from iframe to Vercel rewrite to fix deep link 404s. That removed the website's header/footer wrapper around the tracker. This PR adds the header/footer directly to the tracker app to restore the navigation chrome.
Header (commit 1)
designTokens.js— no new dependenciesFooter (commit 2 — separate for easy revert)
designTokens.jsApproach
Hand-rolled components — no ui-kit dependency. ui-kit 0.4.0 isn't published (build OOM), and 0.3.1's Header has a different API. Both files have TODO comments linking to ui-kit issues for future replacement.
Verified locally
npm run build) passes/us/state-legislative-tracker/MN/mn-hf4621loads correct bill pageTest plan
npm run buildpasses