Skip to content

Make UK firm Ledger selectors profile-driven#229

Open
MaxGhenis wants to merge 1 commit into
mainfrom
codex/uk-firm-profile-cleanup-20260630
Open

Make UK firm Ledger selectors profile-driven#229
MaxGhenis wants to merge 1 commit into
mainfrom
codex/uk-firm-profile-cleanup-20260630

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Summary

  • replace hardcoded UK firm Ledger record-set constants with a target-profile selector object
  • allow the Ledger-style uk_firms target profile mapping to drive fact record-set selection
  • add regression coverage for custom profile record sets and missing profile targets

This keeps the experimental firm generator compatible with today's facts while moving the source wiring toward the eventual spec-driven path. The remaining support-layout assumptions stay in Python for now and are marked as the next piece to lift into declarative specs.

Tests

  • uv run --project packages/populace-build --extra uk python -m pytest packages/populace-build/tests/test_uk_firm_generation.py
  • uv run ruff check packages/populace-build/src/populace/build/uk_runtime/firm_generation.py packages/populace-build/tests/test_uk_firm_generation.py
  • uv run --project packages/populace-build --extra uk python -m pytest packages/populace-build/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant