Create parameter serializer and convert Infinity and -Infinity to np.inf and -np.inf#116
Merged
nikhilwoodruff merged 5 commits intomainfrom May 15, 2025
Merged
Create parameter serializer and convert Infinity and -Infinity to np.inf and -np.inf#116nikhilwoodruff merged 5 commits intomainfrom
nikhilwoodruff merged 5 commits intomainfrom
Conversation
a0418fc to
7a3eb9b
Compare
nikhilwoodruff
approved these changes
May 8, 2025
Collaborator
nikhilwoodruff
left a comment
There was a problem hiding this comment.
This looks good and yes conforms to what I'd expect the schema to be.
Contributor
Author
|
Will merge after tests pass, given addressing of all issues and pre-emptive approval from Nikhil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
This PR:
"Infinity"tonp.infand"-Infinity"to-np.infParametricReformschema to explicitly support and validate three reform input types: