Add TANF administrative calibration targets#747
Closed
MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
Closed
Add TANF administrative calibration targets#747MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
Conversation
|
@MaxGhenis is attempting to deploy a commit to the PolicyEngine Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Closing this fork-based PR in favor of #750 so the repository's full CI can run. The branch is now mirrored to \ with the same commits plus the upstream-branch workflow note in README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds TANF administrative calibration targets from HHS ACF FY2024 data and wires them into the US data build.
It does three things:
bank_account_assets,stock_assets,bond_assets) so follow-up state-specific resource modeling can use explicit asset types instead of survey-reported placeholdersDetails
The new ETL pulls:
Those targets are added at:
tanfspm_unit_countwithdomain_variable: tanftanfspm_unit_countwithdomain_variable: tanfThe old hardcoded national TANF total is removed from
etl_national_targets.py, and the remaining legacy fallback is aligned to the same FY2024 ACF cash-assistance total.Scope boundary
This PR does not publish a generic
spm_unit_assetsaggregate. That would be too semantically broad for the current data, because this branch only exposes liquid-asset inputs and many downstream rules still interpretspm_unit_assetsas broader countable resources.It also intentionally does not add state-specific TANF take-up priors. Full-take-up profiling still leaves structural eligibility misses in some states, so inferred state take-up rates are not yet credible. That follow-up belongs after the remaining eligibility/application-month modeling work.
For now, this PR stays on the calibration/data side:
Related context:
Verification
uv run pytest -q tests/unit/test_etl_tanf.py tests/unit/calibration/test_target_config.py tests/unit/calibration/test_loss_targets.py tests/integration/test_cps_generation.py tests/integration/test_database_build.pyuv run ruff check policyengine_us_data/db/etl_tanf.py policyengine_us_data/storage/calibration_targets/pull_hardcoded_targets.py policyengine_us_data/utils/loss.py tests/unit/test_etl_tanf.py tests/unit/calibration/test_loss_targets.py tests/integration/test_cps_generation.py tests/integration/test_database_build.pyTwo fresh independent review passes after the follow-up patch found no remaining actionable issues.