Phase 2b: migrate household flows to the API v2 shadow path#939
Merged
Phase 2b: migrate household flows to the API v2 shadow path#939
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
vercel
bot
temporarily deployed
to
Preview – policyengine-calculator-next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #938
Summary
Householdthe canonical frontend household model for v1/v2 conversionHouseholdAdapterlayer and replace it with focused model/view testsTesting
bun run typecheckbun run vitest run src/tests/unit/models/Household.test.ts src/tests/unit/hooks/useCreateHousehold.test.tsx src/tests/unit/hooks/useUserHousehold.dualWrite.test.tsx src/tests/unit/hooks/useSaveSharedReport.test.tsx src/tests/unit/pathways/report/views/population/PopulationExistingView.test.tsxbun run vitest run src/tests/unit/hooks/useUserHousehold.test.tsx src/tests/unit/hooks/useSaveSharedReport.test.tsxbunx prettier --check src/hooks/useUserHousehold.ts src/adapters/index.ts src/pages/Populations.page.tsx src/tests/unit/models/Household.test.ts src/tests/fixtures/models/v1HouseholdMocks.ts src/tests/unit/pathways/report/views/population/PopulationExistingView.test.tsx