Skip to content

Use national Populace scoping for place repro code#1078

Closed
MaxGhenis wants to merge 2 commits into
mainfrom
codex/national-populace-repro-code-20260701
Closed

Use national Populace scoping for place repro code#1078
MaxGhenis wants to merge 2 commits into
mainfrom
codex/national-populace-repro-code-20260701

Conversation

@MaxGhenis

Copy link
Copy Markdown
Contributor

Summary

  • extend the default Populace region-scoping path to US place/ regions
  • stop default place reproduction code from synthesizing parent state H5 URLs like policyengine-us-data/states/NJ.h5
  • keep explicit historical pinned place dataset URLs reproducible for old reports

This complements PolicyEngine/populace#237, which removes state and congressional-district H5 artifacts from US releases so consumers rely on the single national Populace file plus region scoping.

Verification

  • bun run vitest src/tests/unit/utils/reproducibilityCode.test.ts
  • bunx prettier --check app/src/utils/reproducibilityCode.ts app/src/tests/unit/utils/reproducibilityCode.test.ts
  • bun run eslint src/utils/reproducibilityCode.ts src/tests/unit/utils/reproducibilityCode.test.ts

@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
policyengine-app-v2 Ready Ready Preview, Comment Jul 1, 2026 1:37pm
policyengine-calculator Ready Ready Preview, Comment Jul 1, 2026 1:37pm
policyengine-calculator-next Ready Ready Preview, Comment Jul 1, 2026 1:37pm
policyengine-website Ready Ready Preview, Comment Jul 1, 2026 1:37pm

Request Review

@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Cycle review found a blocker: default US place regions cannot be safely moved to national Populace scoping yet because the current Populace H5 has state_fips and congressional_district_geoid, but no place_fips, and policyengine.py place regions currently have no scoping_strategy. I pushed a revert of this PR's place change. App-v2 main already handles default state and congressional-district regions through Populace region scoping from #1077; this PR should not be merged unless/until Populace emits place_fips and policyengine.py adds place scoping.

@MaxGhenis

Copy link
Copy Markdown
Contributor Author

Closing after cycle review: the only remaining change attempted to move default place regions to national Populace scoping, but the current Populace H5 does not include place_fips and policyengine.py place regions have no scoping strategy yet. State and congressional-district default repro paths are already handled on main by #1077.

@MaxGhenis MaxGhenis closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant