Prevent logging of wind burst explosions and improve BlockExplodeListener (Fixes #830)#873
Open
guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
Open
Prevent logging of wind burst explosions and improve BlockExplodeListener (Fixes #830)#873guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #830 by using the new ExplosionResult system introduced in 1.21 through the Bukkit adapter
It also improves logging for other BlockExplosions by logging bed and respawn anchor explosions respectively as #bed and #respawn_anchor, reducing the amount of explosions logged as a generic "#explosion". Due to the .getExplodedBlockState() method only being added in 1.20, it also goes through the bukkit adapter.
I have removed the checks for #tnt and #end_crystal in BlockExplodeListener because they only trigger the EntityExplodeListerner anyways, so there was no point in maintaining them.